Adding pre-commit actions for local repository editing#40
Open
otherJL0 wants to merge 4 commits intoerezsh:masterfrom
Open
Adding pre-commit actions for local repository editing#40otherJL0 wants to merge 4 commits intoerezsh:masterfrom
otherJL0 wants to merge 4 commits intoerezsh:masterfrom
Conversation
Owner
|
Thanks! I'll have a look. Are you submitting it because you found the code hard to read? |
Author
|
Hey! Not at all, I just like offloading some of the less interesting stuff when working on projects (ie styling, formatting). I've had the chance to set up this kind of local workflow on poetry projects before and I've really enjoyed the results. Right now it's only adding formatting tools but it would be straightforward to include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To streamline local development, several developer tools were added to the pyproject.toml
dev-dependenciessection:pre-commit
isort
black
pylint
Pre-commit is not triggered by default and must be enabled with the following command:
Pre-commit has been configured to:
isortandblackonpreql/files only when a local commit is attemptedisortandblack, the commit succeedsisortandblack, the files are formatted by both tools and the commit fails. Commiting again should result in no issues.